Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blocked by #3748] update logging docs #3886

Closed
wants to merge 31 commits into from
Closed

[blocked by #3748] update logging docs #3886

wants to merge 31 commits into from

Conversation

edenlightning
Copy link
Contributor

What does this PR do?

Closes #1394, #3799

Before submitting

  • Was this discussed/approved via a Github issue? (no need for typos and docs improvements)
  • Did you read the contributor guideline, Pull Request section?
  • Did you make sure your PR does only one thing, instead of bundling different changes together? Otherwise, we ask you to create a separate PR for every change.
  • Did you make sure to update the documentation with your changes?
  • Did you write any new necessary tests?
  • Did you verify new and existing tests pass locally with your changes?
  • If you made a notable change (that affects users), did you update the CHANGELOG?

PR review

Anyone in the community is free to review the PR once the tests have passed.
If we didn't discuss your PR in Github issues there's a high chance it will not be merged.

Did you have fun?

Make sure you had fun coding 🙃

@edenlightning edenlightning changed the title update logging docs [blocked by #3748] update logging docs Oct 6, 2020
@edenlightning
Copy link
Contributor Author

Need to rename once #3748 is merged.

@codecov
Copy link

codecov bot commented Oct 6, 2020

Codecov Report

Merging #3886 into master will increase coverage by 3%.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master   #3886    +/-   ##
=======================================
+ Coverage      84%     87%    +3%     
=======================================
  Files         119     117     -2     
  Lines        9764    9262   -502     
=======================================
- Hits         8169    8028   -141     
+ Misses       1595    1234   -361     

edenlightning and others added 24 commits October 5, 2020 21:01
* Fixes #3668, #3887 as a bonus

* Fixes #3668, #3887 as a bonus
* extensive mlflow test

* revert accidental commits
* Fix docs for auto_lr_find

* change testcode to codeblock

we are not showing a complete example here
* ref

* Mocking Loggers (part 3c, comet) (#3859)

* mock comet

* new line
* fix docker repo issue

* docker

* docker

* docker

* no cudnn

* no cudnn

* try 16.04

Co-authored-by: Jirka Borovec <[email protected]>
* fix lr finder

* changelog

* add test
include mkpatch


fix test
* Rename row_log_interval -> log_every_n_steps
log_save_interval -> flush_logs_every_n_steps

* Changelog

* fixed title underline length

* typo

* Update pytorch_lightning/trainer/trainer.py

Co-authored-by: Jirka Borovec <[email protected]>

* Update pytorch_lightning/trainer/trainer.py

Co-authored-by: Jirka Borovec <[email protected]>

* pep8 + deprecation test

* 'todo: remove in 1.1 comment'

* 1.1 -> 0.11

* log

* docs

* depr API

* add depr tests

* note

* miss

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Jirka Borovec <[email protected]>
* Makes sure logging doesn't ever happen from non-root zero

* Makes sure logging doesn't ever happen from non-root zero

* Makes sure logging doesn't ever happen from non-root zero

* added bug report model

* fix local model

* fix local model

* fix local model

* fix local model
* tpu device check

* replaced with xmp spawn

* Revert "replaced with xmp spawn"

This reverts commit 6835380

* replaced all instances of XLA_AVAILABLE

* moved inner_f to global scope

* made refactors

* added changelog

* added TPU_AVAILABLE variable

* fix codefactor issues

* removed form trainer and early stopping

* add TORCHXLA_AVAILABLE check

* added tests

* refactoring

* Update pytorch_lightning/utilities/xla_device_utils.py

Co-authored-by: Adrian Wälchli <[email protected]>

* updated function names

* fixed bug

* updated CHANGELOG.md

* added todo

* added type hints

* isort and black

Co-authored-by: Adrian Wälchli <[email protected]>
Co-authored-by: William Falcon <[email protected]>
* add current epoch to __dumped_params

* log

* reset

* add to test

* Update CHANGELOG.md

Co-authored-by: Adrian Wälchli <[email protected]>

Co-authored-by: Jirka Borovec <[email protected]>
Co-authored-by: Nicki Skafte <[email protected]>
Co-authored-by: Adrian Wälchli <[email protected]>
* nb steps

* if

* skip

* rev

* seed

* seed
* Added test for logging in validation step when using dict dataset with string value

* fix recursive issue

* fix recursive issue

Co-authored-by: Nathan Painchaud <[email protected]>
Co-authored-by: William Falcon <[email protected]>
@pep8speaks
Copy link

pep8speaks commented Oct 6, 2020

Hello @edenlightning! Thanks for updating this PR.

Line 22:52: W504 line break after binary operator

Comment last updated at 2020-10-06 21:01:21 UTC

@Borda Borda added this to the 0.10.0 milestone Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated documentation for loggers
10 participants